netdev - Re: [net-next V2 05/15] net/mlx5: Replace global mlx5_intf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 12 Oct 2023 14:28:49 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Saeed Mahameed <saeed@...nel.org>, "David S. Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
CC: Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan
	<tariqt@...dia.com>, Shay Drory <shayd@...dia.com>, Mark Bloch
	<mbloch@...dia.com>
Subject: Re: [net-next V2 05/15] net/mlx5: Replace global mlx5_intf_lock with
 HCA devcom component lock



On 10/12/2023 12:27 PM, Saeed Mahameed wrote:
> From: Shay Drory <shayd@...dia.com>
> 
> mlx5_intf_lock is used to sync between LAG changes and its slaves
> mlx5 core dev aux devices changes, which means every time mlx5 core
> dev add/remove aux devices, mlx5 is taking this global lock, even if
> LAG functionality isn't supported over the core dev.
> This cause a bottleneck when probing VFs/SFs in parallel.
> 
> Hence, replace mlx5_intf_lock with HCA devcom component lock, or no
> lock if LAG functionality isn't supported.
> 
> Signed-off-by: Shay Drory <shayd@...dia.com>
> Reviewed-by: Mark Bloch <mbloch@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>