netdev - Re: [net-next V2 12/15] net/mlx5e: Refactor mlx5e_rss_init() and mlx5e_rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc52873b-0d9c-4ec7-9f04-5b99c31c8d8f@intel.com>
Date: Thu, 12 Oct 2023 14:33:15 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Saeed Mahameed <saeed@...nel.org>, "David S. Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
CC: Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan
	<tariqt@...dia.com>, Adham Faris <afaris@...dia.com>
Subject: Re: [net-next V2 12/15] net/mlx5e: Refactor mlx5e_rss_init() and
 mlx5e_rss_free() API's



On 10/12/2023 12:27 PM, Saeed Mahameed wrote:
> From: Adham Faris <afaris@...dia.com>
> 
> Introduce code refactoring below:
> 1) Introduce single API for creating and destroying rss object,
>    mlx5e_rss_create() and mlx5e_rss_destroy() respectively.
> 2) mlx5e_rss_create() constructs and initializes RSS object depends
>    on a function new param enum mlx5e_rss_create_type. Callers (like
>    rx_res.c) will no longer need to allocate RSS object via
>    mlx5e_rss_alloc() and initialize it immediately via
>    mlx5e_rss_init_no_tirs() or mlx5e_rss_init(), this will be done by
>    a single call to mlx5e_rss_create(). Hence, mlx5e_rss_alloc() and
>    mlx5e_rss_init_no_tirs() have been removed from rss.h file and became
>    static functions.
> 
> Signed-off-by: Adham Faris <afaris@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>