netdev - Re: [net-next V2 13/15] net/mlx5e: Preparations for supporting larger number of channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05802372-0c87-47d8-83b7-28cadb5afe79@intel.com>
Date: Thu, 12 Oct 2023 14:35:21 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Saeed Mahameed <saeed@...nel.org>, "David S. Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
CC: Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan
	<tariqt@...dia.com>, Adham Faris <afaris@...dia.com>
Subject: Re: [net-next V2 13/15] net/mlx5e: Preparations for supporting larger
 number of channels



On 10/12/2023 12:27 PM, Saeed Mahameed wrote:
> From: Adham Faris <afaris@...dia.com>
> 
> Data center server CPUs number keeps getting larger with time.
> Currently, our driver limits the number of channels to 128.
> 
> Maximum channels number is enforced and bounded by hardcoded
> defines (en.h/MLX5E_MAX_NUM_CHANNELS) even though the device and machine
> (CPUs num) can allow more.
> 
> Refactor current implementation in order to handle further channels.
> 
> The maximum supported channels number will be increased in the followup
> patch.
> 
> Introduce RQT size calculation/allocation scheme below:
> 1) Preserve current RQT size of 256 for channels number up to 128 (the
>    old limit).
> 2) For greater channels number, RQT size is calculated by multiplying
>    the channels number by 2 and rounding up the result to the nearest
>    power of 2. If the calculated RQT size exceeds the maximum supported
>    size by the NIC, fallback to this maximum RQT size
>    (1 << log_max_rqt_size).
> 
> Since RQT size is no more static, allocate and free the indirection
> table SW shadow dynamically.
> 
> Signed-off-by: Adham Faris <afaris@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>