netdev - Re: [patch net-next] devlink: don't take instance lock for nested handle put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSeOq+I+Z12E/oRC@nanopsycho>
Date: Thu, 12 Oct 2023 08:14:03 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
	edumazet@...gle.com, gal@...dia.com
Subject: Re: [patch net-next] devlink: don't take instance lock for nested
 handle put

Thu, Oct 12, 2023 at 02:20:25AM CEST, kuba@...nel.org wrote:
>On Wed, 11 Oct 2023 15:34:59 +0200 Jiri Pirko wrote:
>> >If parent is guaranteed to exist the read only fields can be accessed
>> >freely and the read-write fields can be cached on children.  
>> 
>> Only reason to access parent currently is netns change notification.
>> See devlink_rel_nested_in_notify().
>> It basically just scheduled delayed work by calling:
>> devlink_rel_nested_in_notify_work_schedule().
>> 
>> When work is processed in
>> devlink_rel_nested_in_notify_work()
>> There is no guarantee the parent exists, therefore devlink_index is used
>> to get the instance and then obj_index to get port/linecard index.
>> 
>> notify_cb() basically sends notification of parent object and that needs
>> parent instance lock. <--- This is why you need to lock the parent.
>> 
>> I see no way how to cache anything on children as you describe in this
>> scenario.
>> 
>> 
>> >Parent has a list of children, it can store/cache a netns pointer on all
>> >of them. When reload happens lock them and update that pointer.
>> >At which point children do not have to lock the parent.  
>> 
>> Access of netns pointer is not a problem. 
>
>The current code is a problem in itself. You added another xarray,
>with some mark, callbacks and unclear locking semantics. All of it
>completely undocumented.

Okay, I will add the documentation. But I thouth it is clear. The parent
instance lock needs to be taken out of child lock. The problem this
patch tries to fix is when the rntl comes into the picture in one flow,
see the patch description.

>
>The RCU lock on top is just fixing one obvious bug I pointed out to you.

Not sure what obvious bug you mean. If you mean the parent-child
lifetime change, I don't know how that would help here. I don't see how.

Plus it has performance implications. When user removes SF port under
instance lock, the SF itself is removed asynchonously out of the lock.
You suggest to remove it synchronously holding the instance lock,
correct? SF removal does not need that lock. Removing thousands of SFs
would take much longer as currently, they are removed in parallel.
You would serialize the removals for no good reason.

>
>Maybe this is completely unfair but I feel like devlink locking has
>been haphazard and semi-broken since the inception. I had to step in 

Well, it got broken over time. I appreciate you helped to fix it.

>to fix it. And now a year later we're back to weird locking and random
>dependencies. The only reason it was merged is because I was on PTO.

Not sure what you mean by that. Locking is quite clear. Why weird?
What's weird exactly? What do you mean by "random dependencies"?

I have to say I feel we got a bit lost in the conversation.