netdev - Re: [PATCH 11/18] nvme-fabrics: parse options 'keyring' and 'tls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 12 Oct 2023 08:24:27 +0200
From: Hannes Reinecke <hare@...e.de>
To: Keith Busch <kbusch@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 linux-nvme@...ts.infradead.org, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH 11/18] nvme-fabrics: parse options 'keyring' and 'tls_key'

On 10/11/23 19:32, Keith Busch wrote:
> On Thu, Aug 24, 2023 at 04:39:18PM +0200, Hannes Reinecke wrote:
>>   	args.ta_data = queue;
>>   	args.ta_my_peerids[0] = pskid;
>>   	args.ta_num_peerids = 1;
>> +	if (nctrl->opts->keyring)
>> +		keyring = key_serial(nctrl->opts->keyring;
> 
> The key_serial call is missing the closing ')'. I fixed it up while
> applying, but a little concerning. I'm guessing you tested with a
> previous version?
> 
Yes, I did. I've tried in this series to implement the suggestion from
Sagi to store the key serial in the 'opts' structure; hence you wouldn't
need to call key_serial here. But then backed it out again as it didn't
make sense.
But that was apparently imperfectly done :-(

> Anyway, I've applied the series to nvme-6.7 since this otherwise looks
> good. I'll let it sit there a day and send a pull request to Jens if the
> build bots don't complain.

Thank you!

I had been wondering if I needed another resend...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman