lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231013070408.1979343-1-make_ruc2021@163.com> Date: Fri, 13 Oct 2023 15:04:08 +0800 From: Ma Ke <make_ruc2021@....com> To: jmaloy@...hat.com, ying.xue@...driver.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Cc: netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org, Ma Ke <make_ruc2021@....com> Subject: [PATCH] tipc: Fix uninit-value access in tipc_nl_node_get_link() Names must be null-terminated strings. If a name which is not null-terminated is passed through netlink, strstr() and similar functions can cause buffer overrun. This patch fixes this issue by returning -EINVAL if a non-null-terminated name is passed. Signed-off-by: Ma Ke <make_ruc2021@....com> --- net/tipc/node.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/tipc/node.c b/net/tipc/node.c index 3105abe97bb9..a02bcd7e07d3 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -2519,6 +2519,9 @@ int tipc_nl_node_get_link(struct sk_buff *skb, struct genl_info *info) return -EINVAL; name = nla_data(attrs[TIPC_NLA_LINK_NAME]); + if (name[strnlen(name, + nla_len(attrs[TIPC_NLA_LINK_NAME]))] != '\0') + return -EINVAL; msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); if (!msg.skb) -- 2.37.2
Powered by blists - more mailing lists