netdev - RE: [Intel-wired-lan] [PATCH net] i40e: sync next_to_clean and next_to_process for programming status desc

Open Source and information security mailing list archives

Message-ID: <BN9PR11MB535411D7CE84B1968F113ED580D2A@BN9PR11MB5354.namprd11.prod.outlook.com>
Date: Fri, 13 Oct 2023 09:57:57 +0000
From: "Arland, ArpanaX" <arpanax.arland@...el.com>
To: "Sarkar, Tirthendu" <tirthendu.sarkar@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	"Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net] i40e: sync next_to_clean and
 next_to_process for programming status desc

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Tirthendu Sarkar
> Sent: Wednesday, October 4, 2023 2:05 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; netdev@...r.kernel.org; Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; bpf@...r.kernel.org; Karlsson, Magnus <magnus.karlsson@...el.com>
> Subject: [Intel-wired-lan] [PATCH net] i40e: sync next_to_clean and next_to_process for programming status desc
>
> When a programming status desc is encountered on the rx_ring, next_to_process is bumped along with cleaned_count but next_to_clean is not. This causes I40E_DESC_UNUSED() macro to misbehave resulting in overwriting whole ring with new buffers.
>
> Update next_to_clean to point to next_to_process on seeing a programming status desc if not in the middle of handling a multi-frag packet. Also, bump cleaned_count only for such case as otherwise next_to_clean buffer may be returned to hardware on reaching clean_threshold.
>
> Fixes: e9031f2da1ae ("i40e: introduce next_to_process to i40e_ring")
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Reported-by: hq.dev+kernel@...fc.xyz
> Reported by: Solomon Peachy <pizza@...ftnet.org>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217678
> Tested-by: hq.dev+kernel@...fc.xyz
> Tested by: Indrek Järve <incx@...tbite.net>
> Signed-off-by: Tirthendu Sarkar <tirthendu.sarkar@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>

Tested-by: Arpana Arland <arpanax.arland@...el.com> (A Contingent worker at Intel)
______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@...osl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives