netdev - Re: [net-next PATCH v2] octeon_ep: pack hardware structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231013111505.GE29570@kernel.org>
Date: Fri, 13 Oct 2023 13:15:05 +0200
From: Simon Horman <horms@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: pabeni@...hat.com, linux-kernel@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, egallen@...hat.com, hgani@...vell.com,
	kuba@...nel.org, mschmidt@...hat.com, netdev@...r.kernel.org,
	sedara@...vell.com, vburru@...vell.com, vimleshk@...vell.com
Subject: Re: [net-next PATCH v2] octeon_ep: pack hardware structures

On Tue, Oct 10, 2023 at 12:40:26PM -0700, Shinas Rasheed wrote:
> Add packed attribute to structures correlating to hardware
> data, as padding is not allowed by hardware.

Hi Shinas,

in the v1 you stated that this is bot a bugfix.
So I am assuming, that by some happy coincidence,
the layout of the structures is the same before and after
this patch. And this patch is thus a cleanup.

If so I think it would be worth noting in the patch description.