netdev - Re: [PATCH net-next] docs: netlink: clean up after deprecating version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZSkpwRJfk4NDmdMd@nanopsycho>
Date: Fri, 13 Oct 2023 13:28:01 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] docs: netlink: clean up after deprecating
 version

Thu, Oct 12, 2023 at 05:43:15PM CEST, kuba@...nel.org wrote:
>Jiri moved version to legacy specs in commit 0f07415ebb78 ("netlink:
>specs: don't allow version to be specified for genetlink").
>Update the documentation.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>---
> .../userspace-api/netlink/genetlink-legacy.rst     | 14 ++++++++++++++
> Documentation/userspace-api/netlink/specs.rst      |  5 -----
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
>diff --git a/Documentation/userspace-api/netlink/genetlink-legacy.rst b/Documentation/userspace-api/netlink/genetlink-legacy.rst
>index 40b82ad5d54a..11710086aba0 100644
>--- a/Documentation/userspace-api/netlink/genetlink-legacy.rst
>+++ b/Documentation/userspace-api/netlink/genetlink-legacy.rst
>@@ -11,6 +11,20 @@ the ``genetlink-legacy`` protocol level.
> Specification
> =============
> 
>+Gobals
>+------
>+
>+Attributes listed directly at the root level of the spec file.
>+
>+version
>+~~~~~~~
>+
>+Generic Netlink family version, default is 1.
>+
>+``version`` has historically been used to introduce family changes
>+which may break backwards compatibility. Since breaking changes
>+are generally not allowed ``version`` is very rarely used.

"should never be used" perhaps?


>+
> Attribute type nests
> --------------------
> 
>diff --git a/Documentation/userspace-api/netlink/specs.rst b/Documentation/userspace-api/netlink/specs.rst
>index cc4e2430997e..40dd7442d2c3 100644
>--- a/Documentation/userspace-api/netlink/specs.rst
>+++ b/Documentation/userspace-api/netlink/specs.rst
>@@ -86,11 +86,6 @@ name
> Name of the family. Name identifies the family in a unique way, since
> the Family IDs are allocated dynamically.
> 
>-version
>-~~~~~~~
>-
>-Generic Netlink family version, default is 1.
>-
> protocol
> ~~~~~~~~
> 
>-- 
>2.41.0
>