netdev - Re: [PATCH 2/3] RFC: dt-bindings: marvell: Rewrite in schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 13 Oct 2023 14:43:08 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Gregory Clement <gregory.clement@...tlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Russell King <linux@...linux.org.uk>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] RFC: dt-bindings: marvell: Rewrite in schema

> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - marvell,mv88e6060

The 6060 is a separate driver. Its not part of mv88e6xxx. So it should
have a binding document of its own.

> +  '#interrupt-cells':
> +    description: The internal interrupt controller only supports triggering
> +      on IRQ_TYPE_LEVEL_HIGH
> +      # FIXME: what is this? this should be one cell should it not?
> +      # the Linux mv88e6xxx driver does not implement .irq_set_type in its irq_chip
> +      # so at least in that implementation the type is flat out ignored.
> +    const: 2

This interrupt controller is for the embedded PHYs. Its is hard wired
active high.

> +  mdio-external:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false
> +    description: Marvell MV88E6xxx switches have an external mdio bus to
> +      access switch ports.

This is used to access external PHYs attached to the ports, not the
ports themselves.

> +
> +  mdio1:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false
> +    description: Older version of mdio-external
> +    deprecated: true
> +    properties:
> +      compatible:
> +        const: marvell,mv88e6xxx-mdio-external

The driver only looks at the compatible. It does not care what the
node is called. So you are going to need to change the driver if you
want this in the schema.

     Andrew