netdev - [PATCH net 0/2] net/sched: sch_hfsc: safely allow 'rt' inner curves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231013151057.2611860-1-pctammela@mojatatu.com>
Date: Fri, 13 Oct 2023 12:10:55 -0300
From: Pedro Tammela <pctammela@...atatu.com>
To: netdev@...r.kernel.org
Cc: jhs@...atatu.com,
	xiyou.wangcong@...il.com,
	jiri@...nulli.us,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	Pedro Tammela <pctammela@...atatu.com>
Subject: [PATCH net 0/2] net/sched: sch_hfsc: safely allow 'rt' inner curves

As reported [1] disallowing 'rt' inner curves breaks already existing
scripts. Even though it doesn't make sense 'qdisc wise' users have been
relying on this behaviour since the qdisc inception.

We need users to update the scripts/applications to use 'sc' or 'ls'
as a inner curve instead of 'rt', but also avoid the UAF found by
Budimir, which was present since the qdisc inception.

Instead of raising an error when classes are added with a 'rt' as a
parent, upgrade the 'rt' to an 'sc' on the fly, avoiding the UAF, and set
a warning for the user. Hopefully the warning laso triggers users to update
their scripts/applications.

[1] https://lore.kernel.org/all/297D84E3-736E-4AB4-B825-264279E2043C@flyingcircus.io/

Pedro Tammela (2):
  Revert "net/sched: sch_hfsc: Ensure inner classes have fsc curve"
  net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner
    curve

 net/sched/sch_hfsc.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

-- 
2.39.2