netdev - Re: [PATCH net-next v5 5/6] ptp: add debugfs interface to see applied channel masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231012163733.1f61a56d@kernel.org>
Date: Thu, 12 Oct 2023 16:37:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Xabier Marquiegui <reibax@...il.com>
Cc: chrony-dev@...ony.tuxfamily.org, davem@...emloft.net, horms@...nel.org,
 jstultz@...gle.com, mlichvar@...hat.com, netdev@...r.kernel.org,
 ntp-lists@...tcorallo.com, richardcochran@...il.com,
 rrameshbabu@...dia.com, shuah@...nel.org, tglx@...utronix.de,
 vinicius.gomes@...el.com
Subject: Re: [PATCH net-next v5 5/6] ptp: add debugfs interface to see
 applied channel masks

On Thu, 12 Oct 2023 00:36:04 +0200 Xabier Marquiegui wrote:
> Jakub Kicinski said:
> > If it's a self-test it should probably be included in the Makefile 
> > so that bots run it.
> 
> Thank you for your input Jakub. It's actually designed as a debug tool for
> humans. I wasn't thinking about self-tests, and I can't really think of how
> that could be pulled of in this specific case. I hope that's ok. If not we
> can try to throw a few ideas around and see if we find a way.

Let's not throw random non-test scripts into selftests. It adds
confusion to our pitiful kernel testing story :(

The netdevsim driver which is supposed to be used for uAPI selftests
now supports PHCs. Maybe we can extend it and build a proper-er test?

Whether we'd then want to move the debugfs entries onto netdevsim
or leave them where you have then now is another question..