netdev - Re: [PATCH v1 net] tcp: Fix listen() warning with v4-mapped-v6 address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJcLQSsbD3pp_9pUwxyy1fBJnyO5Y33Q4t1Q7WmZ0e3yg@mail.gmail.com>
Date: Fri, 13 Oct 2023 18:32:42 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org, 
	syzbot+71e724675ba3958edb31@...kaller.appspotmail.com
Subject: Re: [PATCH v1 net] tcp: Fix listen() warning with v4-mapped-v6 address.

On Tue, Oct 10, 2023 at 3:38 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> syzbot reported a warning [0] introduced by commit c48ef9c4aed3 ("tcp: Fix
> bind() regression for v4-mapped-v6 non-wildcard address.").
>
> After the cited commit, a v4 socket's address matches the corresponding
> v4-mapped-v6 tb2 in inet_bind2_bucket_match_addr(), not vice versa.
>
> During X.X.X.X -> ::ffff:X.X.X.X order bind()s, the second bind() uses
> bhash and conflicts properly without checking bhash2 so that we need not
> check if a v4-mapped-v6 sk matches the corresponding v4 address tb2 in
> inet_bind2_bucket_match_addr().  However, the repro shows that we need
> to check that in a no-conflict case.
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.