netdev - Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing doorbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231012170147.5c0e8148@kernel.org>
Date: Thu, 12 Oct 2023 17:01:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <egallen@...hat.com>,
 <hgani@...vell.com>, <mschmidt@...hat.com>, <netdev@...r.kernel.org>,
 <sedara@...vell.com>, <vburru@...vell.com>, <vimleshk@...vell.com>
Subject: Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing
 doorbell

On Thu, 12 Oct 2023 03:17:06 -0700 Shinas Rasheed wrote:
> Sometimes Tx is completed immediately after doorbell is updated, which
> causes Tx completion routing to update completion bytes before the
> same packet bytes are updated in sent bytes in transmit function, hence
> hitting BUG_ON() in dql_completed(). To avoid this, update BQL
> sent bytes before ringing doorbell.

Please read this:

https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review

And also when you reply to people please use sane quoting.
This: >>>
is used to indicate three levels of quoting.