netdev - Re: [PATCH net-next v2 2/5] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b5b09ab-f5f3-4c61-9ef6-39fbead126bd@lunn.ch>
Date: Sun, 15 Oct 2023 00:22:35 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Gregory Clement <gregory.clement@...tlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Russell King <linux@...linux.org.uk>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/5] dt-bindings: marvell: Add Marvell
 MV88E6060 DSA schema

> +                port@5 {
> +                    reg = <5>;
> +                    phy-mode = "rgmii-id";

It is a Fast Ethernet switch, so it will not be using Reduced Gigabit
MII. 'rev-mii' would be a better choice.

> +                    ethernet = <&ethc>;
> +                    label = "cpu";

label = "cpu" is deprecated, so you probably don't want it in an
example.


    Andrew

---
pw-bot: cr