netdev - Re: pull-request: bluetooth 2023-10-11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZ+A9Zk8HbQBPNXFLbaR_maCY7o5qHtx_MTJqhQ=LNBMPQ@mail.gmail.com>
Date: Fri, 13 Oct 2023 20:12:56 -0700
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, linux-bluetooth@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: pull-request: bluetooth 2023-10-11

Hi Jakub,

On Fri, Oct 13, 2023 at 5:54 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 11 Oct 2023 12:15:24 -0700 Luiz Augusto von Dentz wrote:
> >  - Fix race when opening vhci device
> >  - Avoid memcmp() out of bounds warning
> >  - Correctly bounds check and pad HCI_MON_NEW_INDEX name
> >  - Fix using memcmp when comparing keys
> >  - Ignore error return for hci_devcd_register() in btrtl
> >  - Always check if connection is alive before deleting
> >  - Fix a refcnt underflow problem for hci_conn
>
> Commit: fc11ae648f03 ("Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name")
>         Fixes tag: Fixes: 78480de55a96 ("Bluetooth: hci_sock: fix slab oob read in create_monitor_event")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> Commit: 6f0ff718ed67 ("Bluetooth: avoid memcmp() out of bounds warning")
>         Fixes tag: Fixes: d70e44fef8621 ("Bluetooth: Reject connection with the device which has same BD_ADDR")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> Commit: b03f32b195df ("Bluetooth: hci_event: Fix coding style")
>         Fixes tag: Fixes: d70e44fef862 ("Bluetooth: Reject connection with the device which has same BD_ADDR")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> Commit: a9500f272b3b ("Bluetooth: hci_event: Fix using memcmp when comparing keys")
>         Fixes tag: Fixes: fe7a9da4fa54 ("Bluetooth: hci_event: Ignore NULL link key")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> :(

Not sure what I'm doing wrong, because verify_fixes.sh doesn't
actually warn these for me, or perhaps it needs to be used in a clean
tree/new clone since it may match commit ids of different
branchs/remotes? Anyway, I'm preparing a new pull-request.

-- 
Luiz Augusto von Dentz