netdev - Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 14 Oct 2023 08:00:51 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "Johannes Berg" <johannes@...solutions.net>,  "Arnd Bergmann"
 <arnd@...db.de>,  "Jiri Pirko" <jiri@...nulli.us>,  "Arnd Bergmann"
 <arnd@...nel.org>,  Netdev <netdev@...r.kernel.org>,  "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>,  linux-wireless@...r.kernel.org,
  linux-wpan@...r.kernel.org,  "Michael Hennerich"
 <michael.hennerich@...log.com>,  "Paolo Abeni" <pabeni@...hat.com>,  "Eric
 Dumazet" <edumazet@...gle.com>,  "David S . Miller" <davem@...emloft.net>,
  "Rodolfo Zitellini" <rwz@...ro.org>,  linux-doc@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support
 conditional

Jakub Kicinski <kuba@...nel.org> writes:

> On Wed, 11 Oct 2023 17:57:38 +0200 Arnd Bergmann wrote:
>> The .ndo_do_ioctl() netdev operation used to be how one communicates
>> with a network driver from userspace, but since my previous cleanup [1],
>> it is purely internal to the kernel.
>> 
>> Removing the cops appletalk/localtalk driver made me revisit the
>> missing pieces from that older series, removing all the unused
>> implementations in wireless drivers as well as the two kernel-internal
>> callers in the ieee802154 and appletalk stacks.
>> 
>> One ethernet driver was already merged in the meantime that should
>> have used .ndo_eth_ioctl instead of .ndo_do_ioctl, so fix that as well.
>> With the complete removal, any future drivers making this mistake
>> cause build failures that are easier to spot.
>> 
>> [1] https://lore.kernel.org/netdev/20201106221743.3271965-1-arnd@kernel.org/
>
> Kalle, Johannes, do these apply for you?
> I'm getting a small conflict on patch 8 and bigger one on patch 9.

Yes, 'git am -3' was able to solve the conflicts automatically and these
do apply to wireless-next.

> If this applies for you maybe you can take it and flush out
> wireless-next soon after?

Ok, we'll do that. Does next Wednesday sound soon enough? :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches