lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231014071423.UgDor1v0@linutronix.de> Date: Sat, 14 Oct 2023 09:14:23 +0200 From: Nam Cao <namcao@...utronix.de> To: Gilbert Adikankwu <gilbertadikankwu@...il.com> Cc: outreachy@...ts.linux.dev, manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com, coiby.xu@...il.com, gregkh@...uxfoundation.org, netdev@...r.kernel.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: qlge: Add bool type to qlge_idc_wait() On Sat, Oct 14, 2023 at 08:58:13AM +0200, Nam Cao wrote: > On Sat, Oct 14, 2023 at 07:11:59AM +0100, Gilbert Adikankwu wrote: > > Reported by checkpatch: > > > > WARNING: else is not generally useful after a break or return > > > > What checkpatch is telling you here is that the "else" is redundant and > can be removed. Although your patch suppresses the warning, it makes the > code messier :( Ah wait, after reading Julia's comment, I realize that the "else" is not redundant at all. Seems like checkpatch.pl is lying. So ignore what I said.
Powered by blists - more mailing lists