netdev - Re: [PATCH net-next v4 1/4] rust: core abstractions for network PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231015.081849.2094682155986954086.fujita.tomonori@gmail.com>
Date: Sun, 15 Oct 2023 08:18:49 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch, miguel.ojeda.sandonis@...il.com
Cc: benno.lossin@...ton.me, fujita.tomonori@...il.com,
 netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, tmgross@...ch.edu,
 boqun.feng@...il.com, wedsonaf@...il.com, greg@...ah.com
Subject: Re: [PATCH net-next v4 1/4] rust: core abstractions for network
 PHY drivers

On Sat, 14 Oct 2023 19:00:46 +0200
Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:

> On Sat, Oct 14, 2023 at 4:13 AM Andrew Lunn <andrew@...n.ch> wrote:
>>
>> To some extent, this is just a temporary location. Once the
>> restrictions of the build systems are solved, i expect this will move
>> into drivers/net/phy/Kconfig, inside the 'if PHYLIB'. However, i
>> agree, this should be under the Rust menu.
> 
> No, it is orthogonal to the build system restrictions.
> 
> In other words, the Kconfig entry could be moved there already. In
> fact, I would suggest so.

Andrew, if you prefer, I'll move RUST_PHYLIB_ABSTRACTIONS to
drivers/net/phy/Kconfig.

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index e55b71937f01..0d39b97a546c 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -66,6 +66,14 @@ config SFP
 	depends on HWMON || HWMON=n
 	select MDIO_I2C
 
+config RUST_PHYLIB_ABSTRACTIONS
+        bool "PHYLIB abstractions support"
+        depends on RUST
+        depends on PHYLIB=y
+        help
+          Adds support needed for PHY drivers written in Rust. It provides
+          a wrapper around the C phylib core.
+
 comment "MII PHY device drivers"
 
 config AMD_PHY