lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231016092700.GH1501712@kernel.org> Date: Mon, 16 Oct 2023 11:27:00 +0200 From: Simon Horman <horms@...nel.org> To: Takeru Hayasaka <hayatake396@...il.com> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool On Thu, Oct 12, 2023 at 06:01:15AM +0000, Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using > ethtool. > A user can include her TEID and make RSS work for GTP-U over IPv4 by > doing the following: > `ethtool -N ens3 rx-flow-hash gtpu4 sde` > In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e, > gtpu(4|6)u, and gtpu(4|6)d. > > GTP generates a flow that includes an ID called TEID to identify the > tunnel. This tunnel is created for each UE (User Equipment). > By performing RSS based on this flow, it is possible to apply RSS for > each communication unit from the UE. > Without this, RSS would only be effective within the range of IP > addresses. > For instance, the PGW can only perform RSS within the IP range of the > SGW. > problematic from a load distribution perspective, especially if there's > a bias in the terminals connected to a particular base station. > This case can be solved by using this patch > > Signed-off-by: Takeru Hayasaka <hayatake396@...il.com> > --- > Added commit messages and options based on reviews Thanks Hayasaka-san, Overall this looks good to me. And I see that the review of v1 has been addressed - by adding information about the need for this to the commit message. Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists