netdev - Re: [PATCH] staging: qlge: Add bool type to qlge_idc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78f321db-bc09-06e8-b4ef-ac56ab91e187@intel.com>
Date: Mon, 16 Oct 2023 16:19:09 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Gilbert Adikankwu <gilbertadikankwu@...il.com>, Nam Cao
	<namcao@...utronix.de>
CC: <outreachy@...ts.linux.dev>, <manishc@...vell.com>,
	<GR-Linux-NIC-Dev@...vell.com>, <coiby.xu@...il.com>,
	<gregkh@...uxfoundation.org>, <netdev@...r.kernel.org>,
	<linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: qlge: Add bool type to qlge_idc_wait()

On 10/14/23 09:50, Gilbert Adikankwu wrote:
> On Sat, Oct 14, 2023 at 09:14:23AM +0200, Nam Cao wrote:
>> On Sat, Oct 14, 2023 at 08:58:13AM +0200, Nam Cao wrote:
>>> On Sat, Oct 14, 2023 at 07:11:59AM +0100, Gilbert Adikankwu wrote:
>>>> Reported by checkpatch:
>>>>
>>>> WARNING: else is not generally useful after a break or return
>>>>
>>>
>>> What checkpatch is telling you here is that the "else" is redundant and
>>> can be removed. Although your patch suppresses the warning, it makes the
>>> code messier :(
>>
>> Ah wait, after reading Julia's comment, I realize that the "else" is not
>> redundant at all. Seems like checkpatch.pl is lying. So ignore what I
>> said.
> 
> Thanks
> 
> 

Could you consider fixing checkpatch instead?