netdev - Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd582b91-141e-48ba-9fa9-01186c02b075@intel.com>
Date: Mon, 16 Oct 2023 09:27:07 -0600
From: Ahmed Zaki <ahmed.zaki@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <mkubecek@...e.cz>, <andrew@...n.ch>, Willem de Bruijn
	<willemdebruijn.kernel@...il.com>, Wojciech Drewek
	<wojciech.drewek@...el.com>, <corbet@....net>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <jesse.brandeburg@...el.com>,
	<edumazet@...gle.com>, <anthony.l.nguyen@...el.com>, <horms@...nel.org>,
	<vladimir.oltean@....com>, <intel-wired-lan@...ts.osuosl.org>,
	<pabeni@...hat.com>, <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow
 symmetric-xor RSS hash for any flow type



On 2023-10-16 09:02, Jakub Kicinski wrote:
> On Sat, 14 Oct 2023 06:19:54 -0600 Ahmed Zaki wrote:
>>>> +#define        RXH_SYMMETRIC_XOR       (1 << 30)
>>>> +#define        RXH_DISCARD             (1 << 31)
>>>>
>>>> Are these indentation changes intentional?
>>>>
>>>>
>>>> Yes, for alignment ("RXH_SYMMETRIC_XOR" is too long).
>>>
>>> I think it's preferable to not touch other lines. Among others, that
>>> messes up git blame. But it's subjective. Follow your preference if no
>>> one else chimes in.
>>
>> Jakub,
>>
>> Sorry for late reply, I was off for few days.
>>
>> I'd like to keep this version, I don't see any other comments that needs
>> to be addressed. Can you accept this or need a v4/rebase ?
> 
> I think you should add a comment above the define explaining what
> "symmetric-xor" is. Is this correct?
> 
> /* XOR corresponding source and destination fields, both copies
>   * of the XOR'ed fields are fed into the RSS and RXHASH calculation.
>   */

Sounds good. I will send a new version shortly.