netdev - Re: [PATCH v7 09/11] io_uring/cmd: Introduce SOCKET_URING_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkcybeol.fsf@>
Date: Mon, 16 Oct 2023 14:33:14 -0400
From: Gabriel Krisman Bertazi <krisman@...e.de>
To: Breno Leitao <leitao@...ian.org>
Cc: sdf@...gle.com,  axboe@...nel.dk,  asml.silence@...il.com,
  willemdebruijn.kernel@...il.com,  kuba@...nel.org,  pabeni@...hat.com,
  martin.lau@...ux.dev,  bpf@...r.kernel.org,
  linux-kernel@...r.kernel.org,  netdev@...r.kernel.org,
  io-uring@...r.kernel.org
Subject: Re: [PATCH v7 09/11] io_uring/cmd: Introduce
 SOCKET_URING_OP_GETSOCKOPT

Breno Leitao <leitao@...ian.org> writes:

> Add support for getsockopt command (SOCKET_URING_OP_GETSOCKOPT), where
> level is SOL_SOCKET. This is leveraging the sockptr_t infrastructure,
> where a sockptr_t is either userspace or kernel space, and handled as
> such.
>
> Differently from the getsockopt(2), the optlen field is not a userspace
> pointers. In getsockopt(2), userspace provides optlen pointer, which is
> overwritten by the kernel.  In this implementation, userspace passes a
> u32, and the new value is returned in cqe->res. I.e., optlen is not a
> pointer.
>
> Important to say that userspace needs to keep the pointer alive until
> the CQE is completed.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>

I suspect you forgot to collect my previous r-b on this :).  Either way,
still good to me:

Reviewed-by: Gabriel Krisman Bertazi <krisman@...e.de>

-- 
Gabriel Krisman Bertazi