netdev - Re: [PATCH net] net: usb: smsc95xx: Fix an error code in smsc95xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f77f3e51-9c8d-4460-8521-866ca1953ce5@lunn.ch>
Date: Mon, 16 Oct 2023 20:57:08 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Steve Glendinning <steve.glendinning@...c.com>,
	Steve Glendinning <steve.glendinning@...well.net>,
	UNGLinuxDriver@...rochip.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: usb: smsc95xx: Fix an error code in
 smsc95xx_reset()

On Mon, Oct 16, 2023 at 08:28:10PM +0300, Dan Carpenter wrote:
> Return a negative error code instead of success.
> 
> Fixes: 2f7ca802bdae ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Hi Dan

It would be nice to use one of the linux/iopoll.h helpers, so avoiding
problems like this. But this is a good minimal fix.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew