netdev - Re: [PATCH] net: txgbe: clean up PBA string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23d363d0-70d6-42b7-9efd-d9953b3bc7f5@lunn.ch>
Date: Mon, 16 Oct 2023 21:19:13 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	mengyuanlou@...-swift.com
Subject: Re: [PATCH] net: txgbe: clean up PBA string

On Mon, Oct 16, 2023 at 05:48:31PM +0800, Jiawen Wu wrote:
> Replace deprecated strncpy with strscpy, and add the missing PBA prints.
> 
> This issue is reported by: Justin Stitt <justinstitt@...gle.com>
> Link: https://lore.kernel.org/netdev/002101d9ffdd$9ea59f90$dbf0deb0$@trustnetic.com/T/#t
> 
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> ---
>  drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
> index 394f699c51da..123e3ca78ef0 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
> @@ -741,8 +741,9 @@ static int txgbe_probe(struct pci_dev *pdev,
>  	/* First try to read PBA as a string */
>  	err = txgbe_read_pba_string(wx, part_str, TXGBE_PBANUM_LENGTH);
>  	if (err)
> -		strncpy(part_str, "Unknown", TXGBE_PBANUM_LENGTH);
> +		strscpy(part_str, "Unknown", sizeof(part_str));
>  
> +	netif_info(wx, probe, netdev, "PBA No: %s\n", part_str);
>  	netif_info(wx, probe, netdev, "%pM\n", netdev->dev_addr);

In general, we try not to spam the kernel log, especially not for the
good case. You can get the MAC address with ip link show. How
important is the part? Can you get the same information from lspci?
Or maybe you could append it to the driver name in wx_get_drvinfo()?

	Andrew