netdev - Re: [PATCH net 4/5] net: move altnames together with the netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZS49CjLECQHdcQwv@nanopsycho>
Date: Tue, 17 Oct 2023 09:51:38 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net 4/5] net: move altnames together with the netdevice

Mon, Oct 16, 2023 at 10:16:56PM CEST, kuba@...nel.org wrote:
>The altname nodes are currently not moved to the new netns
>when netdevice itself moves:
>
>  [ ~]# ip netns add test
>  [ ~]# ip -netns test link add name eth0 type dummy
>  [ ~]# ip -netns test link property add dev eth0 altname some-name
>  [ ~]# ip -netns test link show dev some-name
>  2: eth0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/ether 1e:67:ed:19:3d:24 brd ff:ff:ff:ff:ff:ff
>      altname some-name
>  [ ~]# ip -netns test link set dev eth0 netns 1
>  [ ~]# ip link
>  ...
>  3: eth0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/ether 02:40:88:62:ec:b8 brd ff:ff:ff:ff:ff:ff
>      altname some-name
>  [ ~]# ip li show dev some-name
>  Device "some-name" does not exist.
>
>Remove them from the hash table when device is unlisted
>and add back when listed again.
>
>Fixes: 36fbf1e52bd3 ("net: rtnetlink: add linkprop commands to add and delete alternative ifnames")
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Nice, thanks!

Reviewed-by: Jiri Pirko <jiri@...dia.com>