| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZS5BrH1AOVJyt6ac@shredder> Date: Tue, 17 Oct 2023 11:11:24 +0300 From: Ido Schimmel <idosch@...dia.com> To: Jiri Pirko <jiri@...nulli.us> Cc: netdev@...r.kernel.org, linux-pci@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, bhelgaas@...gle.com, alex.williamson@...hat.com, lukas@...ner.de, petrm@...dia.com, jiri@...dia.com, mlxsw@...dia.com Subject: Re: [RFC PATCH net-next 02/12] devlink: Hold a reference on parent device On Tue, Oct 17, 2023 at 09:56:18AM +0200, Jiri Pirko wrote: > Tue, Oct 17, 2023 at 09:42:47AM CEST, idosch@...dia.com wrote: > >Each devlink instance is associated with a parent device and a pointer > >to this device is stored in the devlink structure, but devlink does not > >hold a reference on this device. > > > >This is going to be a problem in the next patch where - among other > >things - devlink will acquire the device lock during netns dismantle, > >before the reload operation. Since netns dismantle is performed > >asynchronously and since a reference is not held on the parent device, > >it will be possible to hit a use-after-free. > > > >Prepare for the upcoming change by holding a reference on the parent > >device. > > > > Just a note, I'm currently pushing the same patch as a part > of my patchset: > https://lore.kernel.org/all/20231013121029.353351-4-jiri@resnulli.us/ Then you probably need patch #1 as well: https://lore.kernel.org/netdev/20231017074257.3389177-2-idosch@nvidia.com/
Powered by blists - more mailing lists