netdev - Re: [PATCH net-next 4/6] uapi: mptcp: use header file generated from YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231017085813.GP1751252@kernel.org>
Date: Tue, 17 Oct 2023 10:58:13 +0200
From: Simon Horman <horms@...nel.org>
To: Davide Caratti <dcaratti@...hat.com>
Cc: Matthieu Baerts <matttbe@...nel.org>, mptcp@...ts.linux.dev,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Mat Martineau <martineau@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 4/6] uapi: mptcp: use header file generated from
 YAML spec

On Sat, Oct 14, 2023 at 01:37:43PM +0200, Davide Caratti wrote:
> hello Simon, thanks for reading!
> 
> On Fri, Oct 13, 2023 at 7:30 PM Simon Horman <horms@...nel.org> wrote:
> >
> > On Tue, Oct 10, 2023 at 09:21:45PM +0200, Matthieu Baerts wrote:
> > > From: Davide Caratti <dcaratti@...hat.com>
> > >
> > > generated with:
> > >
> > >  $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
> > >  > --spec Documentation/netlink/specs/mptcp.yaml \
> > >  > --header -o include/uapi/linux/mptcp_pm.h
> 
> [...]
> 
> > > +/**
> > > + * enum mptcp_event_type
> >
> > Hi Davide and Matthieu,
> >
> > I understand that is autogenerated.
> > But it is missing an entry here for @MPTCP_EVENT_UNSPEC.
> > Can that be addressed somehow?
> 
> probably it just needs
>     doc: unused event
> 
> in the YAML file, I will add it and regenerate the uAPI header

Thanks!