lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <48fcf444-f411-b4de-7ece-9ec2dfe89d47@blackwall.org> Date: Tue, 17 Oct 2023 12:05:14 +0300 From: Nikolay Aleksandrov <razor@...ckwall.org> To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org, bridge@...ts.linux-foundation.org Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com, roopa@...dia.com, mlxsw@...dia.com Subject: Re: [PATCH net-next 02/13] bridge: mcast: Account for missing attributes On 10/16/23 16:12, Ido Schimmel wrote: > The 'MDBA_MDB' and 'MDBA_MDB_ENTRY' nest attributes are not accounted > for when calculating the size of MDB notifications. Add them along with > comments for existing attributes. > > Signed-off-by: Ido Schimmel <idosch@...dia.com> > --- > net/bridge/br_mdb.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c > index fb58bb1b60e8..08de94bffc12 100644 > --- a/net/bridge/br_mdb.c > +++ b/net/bridge/br_mdb.c > @@ -452,11 +452,18 @@ static int nlmsg_populate_mdb_fill(struct sk_buff *skb, > > static size_t rtnl_mdb_nlmsg_size(struct net_bridge_port_group *pg) > { > - size_t nlmsg_size = NLMSG_ALIGN(sizeof(struct br_port_msg)) + > - nla_total_size(sizeof(struct br_mdb_entry)) + > - nla_total_size(sizeof(u32)); > struct net_bridge_group_src *ent; > - size_t addr_size = 0; > + size_t nlmsg_size, addr_size = 0; > + > + nlmsg_size = NLMSG_ALIGN(sizeof(struct br_port_msg)) + > + /* MDBA_MDB */ > + nla_total_size(0) + > + /* MDBA_MDB_ENTRY */ > + nla_total_size(0) + > + /* MDBA_MDB_ENTRY_INFO */ > + nla_total_size(sizeof(struct br_mdb_entry)) + > + /* MDBA_MDB_EATTR_TIMER */ > + nla_total_size(sizeof(u32)); > > if (!pg) > goto out; Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>
Powered by blists - more mailing lists