[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f4657a17-1b81-f8e3-a781-714f1dc5174f@blackwall.org>
Date: Tue, 17 Oct 2023 12:32:01 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Johannes Nixdorf <jnixdorf-oss@....de>,
"David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
David Ahern <dsahern@...il.com>, Eric Dumazet <edumazet@...gle.com>,
Florian Fainelli <f.fainelli@...il.com>, Ido Schimmel <idosch@...dia.com>,
Jakub Kicinski <kuba@...nel.org>, Oleksij Rempel <linux@...pel-privat.de>,
Paolo Abeni <pabeni@...hat.com>, Roopa Prabhu <roopa@...dia.com>,
Shuah Khan <shuah@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>
Cc: bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v5 4/5] net: bridge: Set strict_start_type for
br_policy
On 10/16/23 16:27, Johannes Nixdorf wrote:
> Set any new attributes added to br_policy to be parsed strictly, to
> prevent userspace from passing garbage.
>
> Signed-off-by: Johannes Nixdorf <jnixdorf-oss@....de>
> ---
> net/bridge/br_netlink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 0c3cf6e6dea2..5ad4abfcb7ba 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -1229,6 +1229,8 @@ static size_t br_port_get_slave_size(const struct net_device *brdev,
> }
>
> static const struct nla_policy br_policy[IFLA_BR_MAX + 1] = {
> + [IFLA_BR_UNSPEC] = { .strict_start_type =
> + IFLA_BR_FDB_N_LEARNED },
> [IFLA_BR_FORWARD_DELAY] = { .type = NLA_U32 },
> [IFLA_BR_HELLO_TIME] = { .type = NLA_U32 },
> [IFLA_BR_MAX_AGE] = { .type = NLA_U32 },
>
Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>
Powered by blists - more mailing lists