netdev - Re: [PATCH iwl-next v4] ice: read internal temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 17 Oct 2023 17:49:12 +0800
From: kernel test robot <lkp@...el.com>
To: Konrad Knitter <konrad.knitter@...el.com>,
	intel-wired-lan@...ts.osuosl.org
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	jdelvare@...e.com, linux@...ck-us.net,
	Konrad Knitter <konrad.knitter@...el.com>,
	Marcin Domagala <marcinx.domagala@...el.com>,
	Eric Joyner <eric.joyner@...el.com>,
	Marcin Szycik <marcin.szycik@...ux.intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next v4] ice: read internal temperature sensor

Hi Konrad,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ac4dec3fd63c7da703c244698fc92efb411ff0d4]

url:    https://github.com/intel-lab-lkp/linux/commits/Konrad-Knitter/ice-read-internal-temperature-sensor/20231017-142048
base:   ac4dec3fd63c7da703c244698fc92efb411ff0d4
patch link:    https://lore.kernel.org/r/20231016102913.898932-1-konrad.knitter%40intel.com
patch subject: [PATCH iwl-next v4] ice: read internal temperature sensor
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171740.MOWYti1J-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171740.MOWYti1J-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171740.MOWYti1J-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/intel/ice/ice_common.c:5329: warning: Excess function parameter 'sensor' description in 'ice_aq_get_sensor_reading'
>> drivers/net/ethernet/intel/ice/ice_common.c:5329: warning: Excess function parameter 'format' description in 'ice_aq_get_sensor_reading'


vim +5329 drivers/net/ethernet/intel/ice/ice_common.c

  5317	
  5318	/**
  5319	 * ice_aq_get_sensor_reading
  5320	 * @hw: pointer to the HW struct
  5321	 * @sensor: sensor type
  5322	 * @format: requested response format
  5323	 * @data: pointer to data to be read from the sensor
  5324	 *
  5325	 * Get sensor reading (0x0632)
  5326	 */
  5327	int ice_aq_get_sensor_reading(struct ice_hw *hw,
  5328				      struct ice_aqc_get_sensor_reading_resp *data)
> 5329	{
  5330		struct ice_aqc_get_sensor_reading *cmd;
  5331		struct ice_aq_desc desc;
  5332		int status;
  5333	
  5334		ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_sensor_reading);
  5335		cmd = &desc.params.get_sensor_reading;
  5336	#define ICE_INTERNAL_TEMP_SENSOR_FORMAT	0
  5337	#define ICE_INTERNAL_TEMP_SENSOR	0
  5338		cmd->sensor = ICE_INTERNAL_TEMP_SENSOR;
  5339		cmd->format = ICE_INTERNAL_TEMP_SENSOR_FORMAT;
  5340	
  5341		status = ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
  5342		if (!status)
  5343			memcpy(data, &desc.params.get_sensor_reading_resp,
  5344			       sizeof(*data));
  5345	
  5346		return status;
  5347	}
  5348	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki