netdev - Re: [net-next PATCH v2] net: skb_find_text: Ignore patterns extending past 'to'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZS5lNz5bqMus/K9L@calendula>
Date: Tue, 17 Oct 2023 12:43:03 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Florian Westphal <fw@...len.de>
Cc: Phil Sutter <phil@....cc>, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [net-next PATCH v2] net: skb_find_text: Ignore patterns
 extending past 'to'

On Tue, Oct 17, 2023 at 12:09:39PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@....cc> wrote:
> > Assume that caller's 'to' offset really represents an upper boundary for
> > the pattern search, so patterns extending past this offset are to be
> > rejected.
> > 
> > The old behaviour also was kind of inconsistent when it comes to
> > fragmentation (or otherwise non-linear skbs): If the pattern started in
> > between 'to' and 'from' offsets but extended to the next fragment, it
> > was not found if 'to' offset was still within the current fragment.
> > 
> > Test the new behaviour in a kselftest using iptables' string match.
> 
> Reviewed-by: Florian Westphal <fw@...len.de>

Reviewed-by: Pablo Neira Ayuso <pablo@...filter.org>