netdev - Re: [net-next PATCH v3 3/4] net: stmmac: move TX timer arm after DMA enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231016180849.1cc29549@kernel.org>
Date: Mon, 16 Oct 2023 18:08:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Raju Rangoju <rajur@...lsio.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose
 Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Ping-Ke Shih <pkshih@...ltek.com>, Kalle Valo <kvalo@...nel.org>, Simon
 Horman <horms@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jiri
 Pirko <jiri@...nulli.us>, Hangbin Liu <liuhangbin@...il.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-wireless@...r.kernel.org
Subject: Re: [net-next PATCH v3 3/4] net: stmmac: move TX timer arm after
 DMA enable

On Sat, 14 Oct 2023 11:29:53 +0200 Christian Marangi wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 5124ee87286c..240a18b97825 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2545,7 +2545,8 @@ static void stmmac_bump_dma_threshold(struct stmmac_priv *priv, u32 chan)
>   * @queue: TX queue index
>   * Description: it reclaims the transmit resources after transmission completes.
>   */
> -static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue)
> +static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue,
> +			   bool *pending_packets)

Missing kdoc for new param, build with W=1 catches this.
-- 
pw-bot: cr