netdev - Re: [PATCH v2 0/2] net: fec: Fix device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 17 Oct 2023 09:37:19 -0500
From: Rob Herring <robh@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, 
	Clark Wang <xiaoning.wang@....com>, "David S . Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	NXP Linux Team <linux-imx@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 0/2] net: fec: Fix device_get_match_data usage

On Tue, Oct 17, 2023 at 1:34 AM Alexander Stein
<alexander.stein@...tq-group.com> wrote:
>
> Hi,
>
> this is v2 adressing the regression introduced by commit b0377116decd
> ("net: ethernet: Use device_get_match_data()").
>
> Changes in v2:
> * Update the OF device data pointers to the actual device specific struct
>   fec_devinfo.
> * Add Patch 2 (unrelated to regression) to remove platform IDs for
>   non-Coldfire
>
> You could also remove the (!dev_info) case for Coldfire as this platform
> has no quirks. But IMHO this should be kept as long as Coldfire platform
> data is supported.
>
> Best regards,
> Alexander
>
> Alexander Stein (2):
>   net: fec: Fix device_get_match_data usage
>   net: fec: Remove non-Coldfire platform IDs
>
>  drivers/net/ethernet/freescale/fec_main.c | 63 ++++-------------------
>  1 file changed, 10 insertions(+), 53 deletions(-)

Reviewed-by: Rob Herring <robh@...nel.org>

Thanks for fixing this.

Rob