lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5a962ea2ab9a40b1da11d95cdaf990002ffed7fa.1697568757.git.nandhakumar.singaram@gmail.com> Date: Tue, 17 Oct 2023 12:06:23 -0700 From: Nandha Kumar Singaram <nandhakumar.singaram@...il.com> To: Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Coiby Xu <coiby.xu@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, netdev@...r.kernel.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Cc: kumaran.4353@...il.com Subject: [PATCH 2/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x) Adhere to linux coding style. Replace the occurrences of (1<<x) by BIT(x) Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@...il.com> --- drivers/staging/qlge/qlge_main.c | 8 ++++---- drivers/staging/qlge/qlge_mpi.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 1ead7793062a..9f67e44123cc 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -2191,7 +2191,7 @@ static int qlge_napi_poll_msix(struct napi_struct *napi, int budget) /* If this TX completion ring belongs to this vector and * it's not empty then service it. */ - if ((ctx->irq_mask & (1 << trx_ring->cq_id)) && + if ((ctx->irq_mask & BIT(trx_ring->cq_id)) && (qlge_read_sh_reg(trx_ring->prod_idx_sh_reg) != trx_ring->cnsmr_idx)) { netif_printk(qdev, intr, KERN_DEBUG, qdev->ndev, @@ -3222,13 +3222,13 @@ static void qlge_set_irq_mask(struct qlge_adapter *qdev, struct intr_context *ct /* Add the RSS ring serviced by this vector * to the mask. */ - ctx->irq_mask = (1 << qdev->rx_ring[vect].cq_id); + ctx->irq_mask = BIT(qdev->rx_ring[vect].cq_id); /* Add the TX ring(s) serviced by this vector * to the mask. */ for (j = 0; j < tx_rings_per_vector; j++) { ctx->irq_mask |= - (1 << qdev->rx_ring[qdev->rss_ring_count + + BIT(qdev->rx_ring[qdev->rss_ring_count + (vect * tx_rings_per_vector) + j].cq_id); } } else { @@ -3236,7 +3236,7 @@ static void qlge_set_irq_mask(struct qlge_adapter *qdev, struct intr_context *ct * ID into the mask. */ for (j = 0; j < qdev->rx_ring_count; j++) - ctx->irq_mask |= (1 << qdev->rx_ring[j].cq_id); + ctx->irq_mask |= BIT(qdev->rx_ring[j].cq_id); } } diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index 96a4de6d2b34..ce0b54603071 100644 --- a/drivers/staging/qlge/qlge_mpi.c +++ b/drivers/staging/qlge/qlge_mpi.c @@ -113,7 +113,7 @@ int qlge_own_firmware(struct qlge_adapter *qdev) * core dump and firmware reset after an error. */ temp = qlge_read32(qdev, STS); - if (!(temp & (1 << (8 + qdev->alt_func)))) + if (!(temp & BIT((8 + qdev->alt_func)))) return 1; return 0; -- 2.25.1
Powered by blists - more mailing lists