lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231017200207.GA5770@breakpoint.cc> Date: Tue, 17 Oct 2023 22:02:07 +0200 From: Florian Westphal <fw@...len.de> To: Yan Zhai <yan@...udflare.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Aya Levin <ayal@...dia.com>, Tariq Toukan <tariqt@...dia.com>, linux-kernel@...r.kernel.org, kernel-team@...udflare.com, Florian Westphal <fw@...len.de>, Willem de Bruijn <willemdebruijn.kernel@...il.com> Subject: Re: [PATCH v2 net-next] ipv6: avoid atomic fragment on GSO packets Yan Zhai <yan@...udflare.com> wrote: > Refactor __ip6_finish_output code to separate GSO and non-GSO packet > processing. It mirrors __ip_finish_output logic now. Add an extra check > in GSO handling to avoid atomic fragments. Lastly, drop dst_allfrag > check, which is no longer true since commit 9d289715eb5c ("ipv6: stop > sending PTB packets for MTU < 1280"). > - if ((skb->len > mtu && !skb_is_gso(skb)) || > - dst_allfrag(skb_dst(skb)) || My preference is to first remove dst_allfrag, i.e. do this in a separate change.
Powered by blists - more mailing lists