| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Oct 2023 13:19:57 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Alexander Duyck <alexander.duyck@...il.com> Cc: Ahmed Zaki <ahmed.zaki@...el.com>, netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, corbet@....net, jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, vladimir.oltean@....com, andrew@...n.ch, horms@...nel.org, mkubecek@...e.cz, willemdebruijn.kernel@...il.com, linux-doc@...r.kernel.org, Wojciech Drewek <wojciech.drewek@...el.com> Subject: Re: [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type On Tue, 17 Oct 2023 13:03:39 -0700 Alexander Duyck wrote: > > > My thought would be to possibly just look at reducing your messaging > > > to a warning from the driver if the inputs are not symmetric, but you > > > have your symmetric xor hash function enabled. > > > > With the restrictions (to be moved into ice_ethtool), the user is unable > > to use non-symmetric inputs. > > I think a warning would make more sense than an outright restriction. > You could warn on both the enabling if the mask is already unbalanced, > or you could warn if the mask is set to be unbalanced after enabling > your hashing. Either it's a valid configuration or we should error out in the core. Keep in mind that we can always _loosen_ the restriction, like you asked for VLAN ID, but we can never _tighten_ it without breaking uAPI. So error.
Powered by blists - more mailing lists