[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1697508125.07194-1-xuanzhuo@linux.alibaba.com>
Date: Tue, 17 Oct 2023 10:02:05 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
virtualization@...ts.linux-foundation.org,
bpf@...r.kernel.org
Subject: Re: [PATCH net-next v1 13/19] virtio_net: xsk: tx: virtnet_free_old_xmit() distinguishes xsk buffer
On Mon, 16 Oct 2023 16:44:34 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon, 16 Oct 2023 20:00:27 +0800 Xuan Zhuo wrote:
> > @@ -305,9 +311,15 @@ static inline void virtnet_free_old_xmit(struct virtnet_sq *sq, bool in_napi,
> >
> > stats->bytes += xdp_get_frame_len(frame);
> > xdp_return_frame(frame);
> > + } else {
> > + stats->bytes += virtnet_ptr_to_xsk(ptr);
> > + ++xsknum;
> > }
> > stats->packets++;
> > }
> > +
> > + if (xsknum)
> > + xsk_tx_completed(sq->xsk.pool, xsknum);
> > }
>
> sparse complains:
>
> drivers/net/virtio/virtio_net.h:322:41: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/virtio/virtio_net.h:322:41: expected struct xsk_buff_pool *pool
> drivers/net/virtio/virtio_net.h:322:41: got struct xsk_buff_pool
> [noderef] __rcu *pool
>
> please build test with W=1 C=1
OK. I will add C=1 to may script.
Thanks.
> --
> pw-bot: cr
Powered by blists - more mailing lists