netdev - Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231017172202.71c8dcf9@kernel.org>
Date: Tue, 17 Oct 2023 17:22:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: netdev@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-wireless@...r.kernel.org, Johannes Berg <johannes@...solutions.net>,
 linux-wpan@...r.kernel.org, Michael Hennerich
 <michael.hennerich@...log.com>, Paolo Abeni <pabeni@...hat.com>, Eric
 Dumazet <edumazet@...gle.com>, "David S . Miller" <davem@...emloft.net>,
 Rodolfo Zitellini <rwz@...ro.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support
 conditional

On Wed, 11 Oct 2023 16:02:16 +0200 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The last localtalk driver is gone now, and ppp support was never fully
> merged, but the code to support them for phase1 networking still calls
> the deprecated .ndo_do_ioctl() helper.
> 
> In order to better isolate the localtalk and ppp portions of appletalk,
> guard all of the corresponding code with CONFIG_DEV_APPLETALK checks,
> including a preprocessor conditional that guards the internal ioctl calls.
> 
> This is currently all dead code and will now be left out of the
> module since this Kconfig symbol is always undefined, but there are
> plans to add a new driver for localtalk again in the future. When
> that happens, the logic can be cleaned up to work properly without
> the need for the ioctl.

Hi Arnd, the WiFi changes are now in net, could you rebase & repost?