netdev - Re: [PATCH net-next v2 02/11] netdevsim: devlink health: use retained error fmsg API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231017182002.716ae87b@kernel.org>
Date: Tue, 17 Oct 2023 18:20:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, "David S .
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Shannon Nelson <shannon.nelson@....com>, Michael
 Chan <michael.chan@...adcom.com>, Cai Huoqing <cai.huoqing@...ux.dev>,
 George Cherian <george.cherian@...vell.com>, Danielle Ratson
 <danieller@...dia.com>, Moshe Shemesh <moshe@...dia.com>, Saeed Mahameed
 <saeedm@...dia.com>, Ariel Elior <aelior@...vell.com>, Manish Chopra
 <manishc@...vell.com>, Igor Russkikh <irusskikh@...vell.com>, Coiby Xu
 <coiby.xu@...il.com>, Brett Creeley <brett.creeley@....com>, Sunil Goutham
 <sgoutham@...vell.com>, Linu Cherian <lcherian@...vell.com>, Geetha
 sowjanya <gakula@...vell.com>, Jerin Jacob <jerinj@...vell.com>, hariprasad
 <hkelam@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>, Ido Schimmel
 <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, Eran Ben Elisha
 <eranbe@...dia.com>, Aya Levin <ayal@...lanox.com>, Leon Romanovsky
 <leon@...nel.org>, linux-kernel@...r.kernel.org, Jesse Brandeburg
 <jesse.brandeburg@...el.com>
Subject: Re: [PATCH net-next v2 02/11] netdevsim: devlink health: use
 retained error fmsg API

On Tue, 17 Oct 2023 12:53:32 +0200 Przemek Kitszel wrote:
> Drop unneeded error checking.
> 
> devlink_fmsg_*() family of functions is now retaining errors,
> so there is no need to check for them after each call.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>