netdev - Re: [PATCH net-next v3 2/2] net:dsa:microchip: add property to select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5202fbb-566e-4dd1-99e9-f07061231a98@lunn.ch>
Date: Wed, 18 Oct 2023 16:09:41 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ante Knezic <ante.knezic@...mholz.de>
Cc: UNGLinuxDriver@...rochip.com, conor+dt@...nel.org, davem@...emloft.net,
	devicetree@...r.kernel.org, edumazet@...gle.com,
	f.fainelli@...il.com, krzysztof.kozlowski+dt@...aro.org,
	kuba@...nel.org, linux-kernel@...r.kernel.org, marex@...x.de,
	netdev@...r.kernel.org, olteanv@...il.com, pabeni@...hat.com,
	robh+dt@...nel.org, woojung.huh@...rochip.com
Subject: Re: [PATCH net-next v3 2/2] net:dsa:microchip: add property to select

On Wed, Oct 18, 2023 at 04:06:28PM +0200, Ante Knezic wrote:
> On Wed, 18 Oct 2023 15:52:27 +0200, Andrew Lunn wrote:
> 
> > It looks like this is the only use of dev->rmii_clk_internal? So does
> > it actually need to be a member of ksz_device? 
> 
> Yes, I guess you are right, sorry about that, it probably won't be used later
> on and should be removed from ksz_device.
> I will repost if the rest of the patch is ok?

The rest looks O.K. to me.

    Andrew

---
pw-bot: cr