netdev - Re: [PATCH v2 net-next 2/5] net-smnp: reorganize SNMP fast path variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e826d9b-cdb6-b0a3-195e-25ead1faf484@kernel.org>
Date: Wed, 18 Oct 2023 08:55:44 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew@...n.ch>
Cc: Coco Li <lixiaoyan@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Neal Cardwell <ncardwell@...gle.com>,
 Mubashir Adnan Qureshi <mubashirq@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 Chao Wu <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>
Subject: Re: [PATCH v2 net-next 2/5] net-smnp: reorganize SNMP fast path
 variables

On 10/17/23 1:15 PM, Eric Dumazet wrote:
> Perhaps add a big comment in the file itself, instead of repeating it
> on future commit changelogs ?

I think a comment in the file would be better. I spent a fair amount of
time reviewing code double checking the impact of the moves; a comment
in that header file would have been helpful.