| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <44d7fba4-3887-50ff-3dd1-3ca39164e6a@ewheeler.net> Date: Wed, 18 Oct 2023 11:44:43 -0700 (PDT) From: Eric Wheeler <netdev@...ts.ewheeler.net> To: Jakub Kicinski <kuba@...nel.org> cc: netdev@...r.kernel.org Subject: Re: BUG: looking up invalid subclass: 8 On Tue, 17 Oct 2023, Jakub Kicinski wrote: > On Tue, 17 Oct 2023 16:41:41 -0700 (PDT) Eric Wheeler wrote: > > I found a similar backtrace that was fixed in > > 3510c7aa069aa83a2de6dab2b41401a198317bdc . It was for ALSA, but had the > > same BUG of "looking up invalid subclass: 8" and the fix was trivial, > > noting that MAX_HOPS shouldn't be bigger than MAX_LOCKDEP_SUBCLASSES. > > > > Is there a simple fix for this in netlink, too? > > > > ]# ./scripts/decode_stacktrace.sh vmlinux `pwd` < stackdump.txt > > [ 113.347055] BUG: looking up invalid subclass: 8 > > [ 113.357387] turning off the locking correctness validator. > > [ 113.364842] Hardware name: Supermicro Super Server/H11SSL-i, BIOS 2.4 12/27/2021 > > [ 113.373614] Call Trace: > > [ 113.381874] <TASK> > > [ 113.382556] dump_stack_lvl (lib/dump_stack.c:108) > > [ 113.388816] look_up_lock_class (kernel/locking/lockdep.c:941) > > [ 113.399562] register_lock_class (kernel/locking/lockdep.c:1284 (discriminator 13)) > > [ 113.400238] ? srso_return_thunk (arch/x86/lib/retpoline.S:308) > > [ 113.403627] __lock_acquire (kernel/locking/lockdep.c:5014) > > [ 113.414652] lock_acquire.part.0 (kernel/locking/lockdep.c:467 kernel/locking/lockdep.c:5755) > > [ 113.428619] ? srso_return_thunk (arch/x86/lib/retpoline.S:308) > > [ 113.435463] ? lock_acquire (./include/trace/events/lock.h:24 kernel/locking/lockdep.c:5724) > > [ 113.440620] _raw_spin_lock_nested (kernel/locking/spinlock.c:379) > > [ 113.462749] ? __nla_validate_parse (lib/nlattr.c:606) > > [ 113.471052] genl_family_rcv_msg_doit.isra.0 (net/netlink/genetlink.c:970) > > [ 113.471651] genl_family_rcv_msg (net/netlink/genetlink.c:1050) > > Thanks for sharing the decoded stack trace, can you share the full > non-decoded one? Is there the name of the command that's calling > this somewhere? > > There's no lock where this is pointing at, just an indirect call. > So I wonder where the lock is. Perhaps retpoline is confusing > the stack trace :( Here it is from two different hosts. This is vanilla v6.5.7: Oct 16 09:48:47 hv1.ewheeler.net kernel: BUG: looking up invalid subclass: 8 Oct 16 09:48:47 hv1.ewheeler.net kernel: turning off the locking correctness validator. Oct 16 09:48:47 hv1.ewheeler.net kernel: CPU: 8 PID: 13275 Comm: drbdsetup-84 Tainted: G E 6.5.7 #23 Oct 16 09:48:47 hv1.ewheeler.net kernel: Hardware name: Supermicro Super Server/H11SSL-i, BIOS 2.4 12/27/2021 Oct 16 09:48:47 hv1.ewheeler.net kernel: Call Trace: Oct 16 09:48:47 hv1.ewheeler.net kernel: <TASK> Oct 16 09:48:47 hv1.ewheeler.net kernel: dump_stack_lvl+0x60/0xa0 Oct 16 09:48:47 hv1.ewheeler.net kernel: look_up_lock_class+0x10b/0x150 Oct 16 09:48:47 hv1.ewheeler.net kernel: register_lock_class+0x48/0x500 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? srso_return_thunk+0x5/0x10 Oct 16 09:48:47 hv1.ewheeler.net kernel: __lock_acquire+0x5f/0xb80 Oct 16 09:48:47 hv1.ewheeler.net kernel: lock_acquire.part.0+0x90/0x210 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? lock_all_resources+0x5a/0x90 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: ? lock_all_resources+0x5a/0x90 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: ? srso_return_thunk+0x5/0x10 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? lock_acquire+0x10b/0x120 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? lock_all_resources+0x5a/0x90 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: _raw_spin_lock_nested+0x33/0x80 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? lock_all_resources+0x5a/0x90 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: lock_all_resources+0x5a/0x90 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: drbd_adm_attach+0x748/0x1340 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: ? __nla_validate_parse+0x13f/0x1f0 Oct 16 09:48:47 hv1.ewheeler.net kernel: genl_family_rcv_msg_doit.isra.0+0xe4/0x150 Oct 16 09:48:47 hv1.ewheeler.net kernel: genl_family_rcv_msg+0x187/0x260 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? __pfx_drbd_adm_attach+0x10/0x10 [drbd] Oct 16 09:48:47 hv1.ewheeler.net kernel: genl_rcv_msg+0x4b/0xb0 Oct 16 09:48:47 hv1.ewheeler.net kernel: ? __pfx_genl_rcv_msg+0x10/0x10 Oct 16 09:48:47 hv1.ewheeler.net kernel: netlink_rcv_skb+0x66/0x120 Oct 16 09:48:47 hv1.ewheeler.net kernel: genl_rcv+0x28/0x40 Oct 16 09:48:47 hv1.ewheeler.net kernel: netlink_unicast+0x1b8/0x280 Oct 16 09:48:47 hv1.ewheeler.net kernel: netlink_sendmsg+0x273/0x520 Oct 16 09:48:47 hv1.ewheeler.net kernel: sock_write_iter+0x188/0x190 Oct 16 09:48:47 hv1.ewheeler.net kernel: vfs_write+0x3e5/0x520 Oct 16 09:48:47 hv1.ewheeler.net kernel: ksys_write+0xc8/0x100 Oct 16 09:48:47 hv1.ewheeler.net kernel: do_syscall_64+0x3f/0xa0 Oct 16 09:48:47 hv1.ewheeler.net kernel: entry_SYSCALL_64_after_hwframe+0x6e/0xd8 Oct 16 09:48:47 hv1.ewheeler.net kernel: RIP: 0033:0x7f41c473e987 Oct 16 09:48:47 hv1.ewheeler.net kernel: Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 Oct 16 09:48:47 hv1.ewheeler.net kernel: RSP: 002b:00007ffe80a28648 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 Oct 16 09:48:47 hv1.ewheeler.net kernel: RAX: ffffffffffffffda RBX: 00000000000000c8 RCX: 00007f41c473e987 Oct 16 09:48:47 hv1.ewheeler.net kernel: RDX: 00000000000000c8 RSI: 000055be8e4f7320 RDI: 0000000000000004 Oct 16 09:48:47 hv1.ewheeler.net kernel: RBP: 000055be8e4f7320 R08: 0000000000000000 R09: 0000000000000000 Oct 16 09:48:47 hv1.ewheeler.net kernel: R10: 0000000000001000 R11: 0000000000000246 R12: 00000000000000c8 Oct 16 09:48:47 hv1.ewheeler.net kernel: R13: 0000000000000004 R14: 00007ffe80a28970 R15: 000055be8d383848 Oct 16 09:48:47 hv1.ewheeler.net kernel: </TASK> And this is a hacked up Oracle UEK 5.15.0-X build with a similar trace: Oct 16 10:56:58 hv2.ewheeler.net [ 406.342188] CPU: 29 PID: 35965 Comm: drbdsetup-84 Kdump: loaded Not tainted 5.15.0-7.86.6.1.el9uek.x86_64-TEST+ #7 Oct 16 10:56:58 hv2.ewheeler.net [ 406.358188] Hardware name: Supermicro Super Server/H11SSL-i, BIOS 2.4 12/27/2021 Oct 16 10:56:58 hv2.ewheeler.net [ 406.374188] Call Trace: Oct 16 10:56:58 hv2.ewheeler.net [ 406.390189] <TASK> Oct 16 10:56:58 hv2.ewheeler.net [ 406.406190] dump_stack_lvl+0x57/0x7e Oct 16 10:56:58 hv2.ewheeler.net [ 406.422187] look_up_lock_class+0xe7/0xfb Oct 16 10:56:58 hv2.ewheeler.net [ 406.438187] register_lock_class+0x3d/0x4db Oct 16 10:56:58 hv2.ewheeler.net [ 406.454191] __lock_acquire+0x56/0xaa3 Oct 16 10:56:58 hv2.ewheeler.net [ 406.469193] lock_acquire+0xc8/0x32d Oct 16 10:56:58 hv2.ewheeler.net [ 406.484192] ? lock_all_resources+0x54/0x80 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.500053] ? find_held_lock+0x32/0x8d Oct 16 10:56:58 hv2.ewheeler.net [ 406.515189] ? lock_all_resources+0x54/0x80 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.530198] ? lock_all_resources+0x54/0x80 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.545186] ? __lock_acquired+0x58/0x278 Oct 16 10:56:58 hv2.ewheeler.net [ 406.559270] _raw_spin_lock_nested+0x2f/0x71 Oct 16 10:56:58 hv2.ewheeler.net [ 406.573191] ? lock_all_resources+0x54/0x80 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.588187] lock_all_resources+0x54/0x80 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.603187] drbd_adm_attach+0x90c/0x1074 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.618191] ? __nla_validate_parse+0x15c/0x1c8 Oct 16 10:56:58 hv2.ewheeler.net [ 406.632189] genl_family_rcv_msg_doit+0xfd/0x169 Oct 16 10:56:58 hv2.ewheeler.net [ 406.646192] genl_family_rcv_msg+0xbe/0x179 Oct 16 10:56:58 hv2.ewheeler.net [ 406.658194] ? drbd_adm_disk_opts.cold+0x77/0x77 [drbd] Oct 16 10:56:58 hv2.ewheeler.net [ 406.672195] genl_rcv_msg+0x47/0xa6 Oct 16 10:56:58 hv2.ewheeler.net [ 406.685194] ? find_held_lock+0x32/0x8d Oct 16 10:56:58 hv2.ewheeler.net [ 406.698199] ? genl_family_rcv_msg+0x180/0x179 Oct 16 10:56:58 hv2.ewheeler.net [ 406.711192] netlink_rcv_skb+0x5c/0x106 Oct 16 10:56:58 hv2.ewheeler.net [ 406.724191] genl_rcv+0x24/0x31 Oct 16 10:56:58 hv2.ewheeler.net [ 406.736197] netlink_unicast+0x1a5/0x261 Oct 16 10:56:58 hv2.ewheeler.net [ 406.749188] netlink_sendmsg+0x24f/0x4d5 Oct 16 10:56:58 hv2.ewheeler.net [ 406.761612] sock_sendmsg+0x68/0x6a Oct 16 10:56:58 hv2.ewheeler.net [ 406.773189] sock_write_iter+0x9e/0x10a Oct 16 10:56:58 hv2.ewheeler.net [ 406.785193] new_sync_write+0x1da/0x1e9 Oct 16 10:56:58 hv2.ewheeler.net [ 406.797193] vfs_write+0x276/0x381 Oct 16 10:56:58 hv2.ewheeler.net [ 406.809188] ksys_write+0xc7/0xf4 Oct 16 10:56:58 hv2.ewheeler.net [ 406.820190] do_syscall_64+0x3b/0x8d Oct 16 10:56:58 hv2.ewheeler.net [ 406.831196] entry_SYSCALL_64_after_hwframe+0x63/0x0 Oct 16 10:56:58 hv2.ewheeler.net [ 406.843192] RIP: 0033:0x7fdc29a1d987 Oct 16 10:56:58 hv2.ewheeler.net [ 406.853533] Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 Oct 16 10:56:58 hv2.ewheeler.net [ 406.877188] RSP: 002b:00007fff4acbe2a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 Oct 16 10:56:58 hv2.ewheeler.net [ 406.889186] RAX: ffffffffffffffda RBX: 00000000000000c8 RCX: 00007fdc29a1d987 Oct 16 10:56:58 hv2.ewheeler.net [ 406.900198] RDX: 00000000000000c8 RSI: 00005583cafa6320 RDI: 0000000000000004 Oct 16 10:56:58 hv2.ewheeler.net [ 406.911508] RBP: 00005583cafa6320 R08: 0000000000000000 R09: 0000000000000000 Oct 16 10:56:58 hv2.ewheeler.net [ 406.922188] R10: 0000000000001000 R11: 0000000000000246 R12: 00000000000000c8 Oct 16 10:56:58 hv2.ewheeler.net [ 406.934189] R13: 0000000000000004 R14: 00007fff4acbe5d0 R15: 00005583ca41d848 Oct 16 10:56:58 hv2.ewheeler.net [ 406.945189] </TASK>
Powered by blists - more mailing lists