netdev - Re: [PATCH net] tcp: fix excessive TLP and RACK timeouts from HZ rounding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169758962254.9987.492571478078988197.git-patchwork-notify@kernel.org>
Date: Wed, 18 Oct 2023 00:40:22 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Neal Cardwell <ncardwell.sw@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] tcp: fix excessive TLP and RACK timeouts from HZ rounding

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sun, 15 Oct 2023 13:47:00 -0400 you wrote:
> From: Neal Cardwell <ncardwell@...gle.com>
> 
> We discovered from packet traces of slow loss recovery on kernels with
> the default HZ=250 setting (and min_rtt < 1ms) that after reordering,
> when receiving a SACKed sequence range, the RACK reordering timer was
> firing after about 16ms rather than the desired value of roughly
> min_rtt/4 + 2ms. The problem is largely due to the RACK reorder timer
> calculation adding in TCP_TIMEOUT_MIN, which is 2 jiffies. On kernels
> with HZ=250, this is 2*4ms = 8ms. The TLP timer calculation has the
> exact same issue.
> 
> [...]

Here is the summary with links:
  - [net] tcp: fix excessive TLP and RACK timeouts from HZ rounding
    https://git.kernel.org/netdev/net/c/1c2709cfff1d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html