netdev - Re: [PATCH net] tcp_bpf: properly release resources on error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65302f7d693a8_b74c20846@john.notmuch>
Date: Wed, 18 Oct 2023 12:18:21 -0700
From: John Fastabend <john.fastabend@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, 
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, 
 John Fastabend <john.fastabend@...il.com>, 
 Jakub Sitnicki <jakub@...udflare.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 David Ahern <dsahern@...nel.org>, 
 Jakub Kicinski <kuba@...nel.org>, 
 bpf@...r.kernel.org
Subject: Re: [PATCH net] tcp_bpf: properly release resources on error paths

Eric Dumazet wrote:
> On Tue, Oct 17, 2023 at 5:50 PM Paolo Abeni <pabeni@...hat.com> wrote:
> >
> > In the blamed commit below, I completely forgot to release the acquired
> > resources before erroring out in the TCP BPF code, as reported by Dan.
> >
> > Address the issues by replacing the bogus return with a jump to the
> > relevant cleanup code.
> >
> > Fixes: 419ce133ab92 ("tcp: allow again tcp_disconnect() when threads are waiting")
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> 
> Right :)
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.

Reviewed-by: John Fastabend <john.fastabend@...il.com>