netdev - Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24f14f0f-2a1b-401d-b5f8-314387d0aaef@pengutronix.de>
Date: Wed, 18 Oct 2023 07:55:21 +0200
From: Johannes Zink <j.zink@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>, Marc Kleine-Budde <mkl@...gutronix.de>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
 Richard Cochran <richardcochran@...il.com>,
 Kurt Kanzenbach <kurt@...utronix.de>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 linux-stm32@...md-mailman.stormreply.com, Eric Dumazet
 <edumazet@...gle.com>, Jose Abreu <joabreu@...opsys.com>,
 Simon Horman <horms@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>,
 linux-arm-kernel@...ts.infradead.org, patchwork-jzi@...gutronix.de
Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index

Hi Jakub, hi Marc,

On 10/18/23 01:50, Jakub Kicinski wrote:
> On Tue, 17 Oct 2023 22:27:41 +0200 Marc Kleine-Budde wrote:
>>> Would be good to clarify what impact on device operation the problem
>>> has. How would end user notice the problem?
>>> Does it mean snapshots were always or never enabled, previously?
>>
>> On all dwmac devices not covered by dwmac-intel.c (INTEL 10/100/1000
>> Ethernet PCI driver), PPS capture can be requested from user-space, but
>> is not enabled in HW. There is no error message or other feedback to the
>> user space. The user space will not get any PPS events.
>>
>> As this change also affects the Intel driver, and we don't have any
>> hardware to test, I think it's better that this goes via net-next to
>> give it a bit more time of testing.

I have also CC'ed Kurt in this series, as I know he has at least some hardware 
at hand, though I cannot tell whether he has any chance to test the PPS 
capture. Maybe he has a possibility to try it out. However, giving it a spin in 
net-next SGTM.

> 
> SGTM, we can chalk it up to "never worked, doesn't hurt anyone"
> and put it in net-next. But then the Fixes tag must go.
> 

sure, that's fine for me. I will reword the commit messages and send a v2.

Best regards,
Johannes

-- 
Pengutronix e.K.                | Johannes Zink                  |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |