netdev - Re: [PATCH net-next] inet: lock the socket in ip_sock_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c74aa6a3fdc417f6573578e084f2a655ddd655b.camel@redhat.com>
Date: Thu, 19 Oct 2023 13:12:00 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Cc: David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, Christoph Paasch <cpaasch@...le.com>
Subject: Re: [PATCH net-next] inet: lock the socket in ip_sock_set_tos()

On Wed, 2023-10-18 at 09:00 +0000, Eric Dumazet wrote:
> diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c
> index 18ce624bfde2a5a451e42148ec7349d1ead2cec3..59bd5e114392a007a71df57217e0ec357aae8229 100644
> --- a/net/mptcp/sockopt.c
> +++ b/net/mptcp/sockopt.c
> @@ -738,7 +738,7 @@ static int mptcp_setsockopt_v4_set_tos(struct mptcp_sock *msk, int optname,
>  	mptcp_for_each_subflow(msk, subflow) {
>  		struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
>  
> -		ip_sock_set_tos(ssk, val);
> +		__ip_sock_set_tos(ssk, val);

[not introduced by this patch] but I think here we need the locked
version.

As a pre-existent issue, I think it's better handled as a separate
patch - that can go through the mptcp CI.

No additional action needed here, thanks!

Paolo