netdev - Re: [PATCH] pds_core: add an error code check in pdsc_dl_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c418625c-755f-4e2f-93e7-f2a5d8c7fba3@amd.com>
Date: Thu, 19 Oct 2023 08:52:52 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Su Hui <suhui@...china.com>, brett.creeley@....com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] pds_core: add an error code check in pdsc_dl_info_get

On 10/19/2023 1:33 AM, Su Hui wrote:
> 
> check the value of 'ret' after call 'devlink_info_version_stored_put'.
> 
> Signed-off-by: Su Hui <suhui@...china.com>

Thanks.

Reviewed-by: Shannon Nelson <shannon.nelson@....com>

> ---
>   drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
> index d9607033bbf2..09041f7fccaf 100644
> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
> @@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
>                          snprintf(buf, sizeof(buf), "fw.slot_%d", i);
>                  err = devlink_info_version_stored_put(req, buf,
>                                                        fw_list.fw_names[i].fw_version);
> +               if (err)
> +                       return err;
>          }
> 
>          err = devlink_info_version_running_put(req,
> --
> 2.30.2
>