netdev - Re: [PATCH net-next v2 10/11] staging: qlge: devlink health: use retained error fmsg API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231019074237.7ef255d7@kernel.org>
Date: Thu, 19 Oct 2023 07:42:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Benjamin Poirier <benjamin.poirier@...il.com>
Cc: Coiby Xu <coiby.xu@...il.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Jiri Pirko <jiri@...nulli.us>,
 netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Shannon
 Nelson <shannon.nelson@....com>, Michael Chan <michael.chan@...adcom.com>,
 Cai Huoqing <cai.huoqing@...ux.dev>, George Cherian
 <george.cherian@...vell.com>, Danielle Ratson <danieller@...dia.com>, Moshe
 Shemesh <moshe@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, Ariel Elior
 <aelior@...vell.com>, Manish Chopra <manishc@...vell.com>, Igor Russkikh
 <irusskikh@...vell.com>, Brett Creeley <brett.creeley@....com>, Sunil
 Goutham <sgoutham@...vell.com>, Linu Cherian <lcherian@...vell.com>, Geetha
 sowjanya <gakula@...vell.com>, Jerin Jacob <jerinj@...vell.com>, hariprasad
 <hkelam@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>, Ido Schimmel
 <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, Eran Ben Elisha
 <eranbe@...dia.com>, Aya Levin <ayal@...lanox.com>, Leon Romanovsky
 <leon@...nel.org>, linux-kernel@...r.kernel.org, Shung-Hsi Yu
 <shung-hsi.yu@...e.com>
Subject: Re: [PATCH net-next v2 10/11] staging: qlge: devlink health: use
 retained error fmsg API

On Thu, 19 Oct 2023 10:28:03 -0400 Benjamin Poirier wrote:
> > Humpf. Unrelated to the set, when did qlge grow devlink support?!
> > 
> > Coiby, do you still use this HW?
> > 
> > It looks like the driver was moved to staging on account of being
> > old and unused, and expecting that we'll delete it. Clearly that's
> > not the case if people are adding devlink support, so should we
> > move it back?  
> 
> AFAIK this was done by Coiby as an exercise in kernel programming.
> Improving the debugging dump facilities was one of the tasks in the TODO
> file.
> 
> I moved the driver to staging because it had many problems and it had
> been abandoned by the vendor. There might be some qlge users left but is
> that reason enough to move the driver back to drivers/net/
> if there is no one who is interested in doing more than checkpatch
> fixes on the driver?

Staging is usually an area for code entering the kernel, not leaving.
We should either suffer with it under drivers/net/ or delete it,
as you say, nobody is working on significant improvements so having 
the driver in staging is serving no purpose.

How about we delete it completely, and if someone complains bring 
it back under drivers/net ?