netdev - Re: [PATCH v2 04/13] linkmode: convert linkmode_{test,set,clear,mod}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231018172754.3eec4885@kernel.org>
Date: Wed, 18 Oct 2023 17:27:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Yury Norov <yury.norov@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, Alexander Potapenko <glider@...gle.com>, Eric
 Dumazet <edumazet@...gle.com>, David Ahern <dsahern@...nel.org>, Przemek
 Kitszel <przemyslaw.kitszel@...el.com>, Simon Horman
 <simon.horman@...igine.com>, netdev@...r.kernel.org,
 linux-btrfs@...r.kernel.org, dm-devel@...hat.com, ntfs3@...ts.linux.dev,
 linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/13] linkmode: convert
 linkmode_{test,set,clear,mod}_bit() to macros

On Mon, 16 Oct 2023 18:52:38 +0200 Alexander Lobakin wrote:
> Since commit b03fc1173c0c ("bitops: let optimize out non-atomic bitops
> on compile-time constants"), the non-atomic bitops are macros which can
> be expanded by the compilers into compile-time expressions, which will
> result in better optimized object code. Unfortunately, turned out that
> passing `volatile` to those macros discards any possibility of
> optimization, as the compilers then don't even try to look whether
> the passed bitmap is known at compilation time. In addition to that,
> the mentioned linkmode helpers are marked with `inline`, not
> `__always_inline`, meaning that it's not guaranteed some compiler won't
> uninline them for no reason, which will also effectively prevent them
> from being optimized (it's a well-known thing the compilers sometimes
> uninline `2 + 2`).
> Convert linkmode_*_bit() from inlines to macros. Their calling
> convention are 1:1 with the corresponding bitops, so that it's not even
> needed to enumerate and map the arguments, only the names. No changes in
> vmlinux' object code (compiled by LLVM for x86_64) whatsoever, but that
> doesn't necessarily means the change is meaningless.

Acked-by: Jakub Kicinski <kuba@...nel.org>

This one can go in with the rest, it's trivial enough.